fix: カードを削除したときにcard_listが二重削除されていた問題を修正 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qithub-BOT#62 でArray#spliceに書き換えたときに消し忘れた ref: - Qithub-BOT#92
|
二重削除問題はよさそうですけど、flipと組み合わせるとおかしくなりました。 |
|
1,1,2,2, -(flip)-> 2,2,1,1, -(add 2)-> 2,2,1,1,2, -(delete ２つ目の2)-> 2,2,1,2 |
|
これはflipの実装がクソっぽい。要素削除はidベースなのにそれを考えてない #81 のせい。 |
Closed
|
なるほど、flipと組み合わせる件はとりあえず別issueでもいいかなと思います（二重削除はdelete単体の問題なので、これがマージされたら改善するという意味で） |
|
別の問題なので当PRでは直しません。 #94 へ |
sasanquaneuf
approved these changes
Jan 13, 2020
KEINOS
approved these changes
Jan 13, 2020
|
Chrome 79.0.3945.117 @ Mac で二重削除されないことを確認しました。LGTM だと思います。 特に他に影響しないと思うのでマージします。 Closing #92 (cc @yume-yu @blhsrwznrghfzpr )
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#62 でArray#spliceに書き換えたときに消し忘れた
resolve #92
ref: